Both have advantages. An on-airport desk can be convenient
because you collect your car within the airport, but busy
desks can sometimes have queues during peak periods.
Off-airport suppliers normally provide transport from the
airport to a nearby rental office. Depending on the supplier
and how busy the airport is, this can sometimes make collection
quicker.
The best choice depends on your circumstances, particularly
if you're travelling with children, lots of luggage or anyone
with reduced mobility.